Dark mode for the forum
Discussion
Clockwork Cupcake said:
Still broken, BTW
We're well aware and it was something that was discussed only yesterday but unfortunately it's not a simple fix like you might think. We appreciate it's frustrating (it is for us too) but other things have been taking priority, but it is on our shortlist for consideration.Ben Lowden said:
Clockwork Cupcake said:
Still broken, BTW
We're well aware and it was something that was discussed only yesterday but unfortunately it's not a simple fix like you might think. We appreciate it's frustrating (it is for us too) but other things have been taking priority, but it is on our shortlist for consideration.
Ben Lowden said:
We're well aware and it was something that was discussed only yesterday but unfortunately it's not a simple fix like you might think. We appreciate it's frustrating (it is for us too) but other things have been taking priority, but it is on our shortlist for consideration.
I can hazard a guess on what it is. I bet you are using a totally different BBCode engine for the garage than you are for the Gassing Station. Which is, of course, utter lunacy. What is happening is that the text of the garage description is getting converted to HTML, then the raw HTML that is generated is getting escaped into plain text, and then re-rendered as HTML
Thus
Line 1
Line 2
becomes
Line 1<br/>Line 2
ie. literally Line 1<br/>Line 2
Clockwork Cupcake said:
Ben Lowden said:
We're well aware and it was something that was discussed only yesterday but unfortunately it's not a simple fix like you might think. We appreciate it's frustrating (it is for us too) but other things have been taking priority, but it is on our shortlist for consideration.
I can hazard a guess on what it is. I bet you are using a totally different BBCode engine for the garage than you are for the Gassing Station. Which is, of course, utter lunacy. What is happening is that the text of the garage description is getting converted to HTML, then the raw HTML that is generated is getting escaped into plain text, and then re-rendered as HTML
Thus
Line 1
Line 2
becomes
Line 1<br/>Line 2
ie. literally Line 1<br/>Line 2
Clockwork Cupcake said:
I can hazard a guess on what it is. I bet you are using a totally different BBCode engine for the garage than you are for the Gassing Station. Which is, of course, utter lunacy.
What is happening is that the text of the garage description is getting converted to HTML, then the raw HTML that is generated is getting escaped into plain text, and then re-rendered as HTML
Thus
Line 1
Line 2
becomes
Line 1<br/>Line 2
ie. literally Line 1<br/>Line 2
As you say the core issue centres around rendering vs escaping of HTML, from the content entered by users. Due to the age of this feature, in the early days, this was built lacking the current security best practices for dealing with user input (i.e. preventing security vulnerabilities) - for this reason, and relative priorities at the time, in order to protect this area of the site from mis-use, we needed to escape this (potentially malicious) content rather than rendering it directly. Its time will come, but we can't say when just yet.What is happening is that the text of the garage description is getting converted to HTML, then the raw HTML that is generated is getting escaped into plain text, and then re-rendered as HTML
Thus
Line 1
Line 2
becomes
Line 1<br/>Line 2
ie. literally Line 1<br/>Line 2
Ben Lowden said:
As you say the core issue centres around rendering vs escaping of HTML, from the content entered by users. Due to the age of this feature, in the early days, this was built lacking the current security best practices for dealing with user input (i.e. preventing security vulnerabilities) - for this reason, and relative priorities at the time, in order to protect this area of the site from mis-use, we needed to escape this (potentially malicious) content rather than rendering it directly. Its time will come, but we can't say when just yet.
I understand your concerns. The thing that points to this being a serious bug is that the engine can't even cope with its own input.
If you were to create a car in your garage and were literally to set the description to
Line 1
Line 2
and then submit
then it will get rendered as "Line 1<br/>Line 2"
So this is not a sanitation issue but a straight out bug, as it cannot even render its own output correctly.
My advice would be to simply strip out all BBCode and HTML for now and go totally plain text. That would be the First Stage fix. Just having it correctly render plain text would be a good first goal because currently it cannot even achieve that.
You can then add BBCode back in later.
toon10 said:
What is it with dark mode that I just don't get? I'm on regular code reviews with younger developers who love it. It's really hard to read. I have to squint and concentrate which is manageable for text but when trying to decipher code, it's just a nightmare.
Totally with you there. I don't get the utter obsession with Dark Mode on everything these days. In Visual Studio and Visual Code (my two primary IDEs) I go old school white background and all my young colleagues look at me like I grew an extra head.
But I just threaten to hit them with my modem
Clockwork Cupcake said:
Totally with you there. I don't get the utter obsession with Dark Mode on everything these days.
In Visual Studio and Visual Code (my two primary IDEs) I go old school white background and all my young colleagues look at me like I grew an extra head.
But I just threaten to hit them with my modem
For some weird ass reason I do like VSCode in dark mode. Not so with VS or any other program. Hate it when it is on by default.In Visual Studio and Visual Code (my two primary IDEs) I go old school white background and all my young colleagues look at me like I grew an extra head.
But I just threaten to hit them with my modem
HappyMidget said:
Clockwork Cupcake said:
Totally with you there. I don't get the utter obsession with Dark Mode on everything these days.
In Visual Studio and Visual Code (my two primary IDEs) I go old school white background and all my young colleagues look at me like I grew an extra head.
But I just threaten to hit them with my modem
For some weird ass reason I do like VSCode in dark mode. Not so with VS or any other program. Hate it when it is on by default.In Visual Studio and Visual Code (my two primary IDEs) I go old school white background and all my young colleagues look at me like I grew an extra head.
But I just threaten to hit them with my modem
As a relative oldie, I cut my teeth wordprocessing using WordPerfect 5.1 for DOS: light text on a blue background. No WYSWYG in that, but a surprisingly restful editing environment. Dark text on a light background has always irked me.
Research suggests avoiding black/white combos - black text on a light grey background, or light grey text on a black/dark background tends to be the easiest on the eyes for the longest period for the greatest number of people.
Ben Lowden said:
We don't have a dark mode and this isn't something we're planning on I'm afraid. We simplified the forum skins to make it much easier for us to maintain the forums with a single theme.
As others have mentioned some browsers may offer dark mode solutions that you could try.
Hi Ben/PH othersAs others have mentioned some browsers may offer dark mode solutions that you could try.
Bumping this to ask if there's any change on the last stance? Alternatives such as dark mode reader extensions are often flawed and dark mode is a huge accessibility enabler for many (I'm sure you know this mind you!).
Merry Christmas
I gave up asking years ago but have had reasonable success with an extension add on for Opera - it is a multi-browser extension I am led to believe . . .
https://mybrowseraddon.com/dark-mode.html
https://mybrowseraddon.com/dark-mode.html
Gassing Station | Website Feedback | Top of Page | What's New | My Stuff