[FIXED] Thumbnail grows small images in quoted posts

[Clockwork Cupcake]

When a reply is quoted, any images are automatically thumbnailed.

However, the code does not check if the image is already smaller than the thumbnail size, meaning that, for example, emoticon images from the emoticon cache hosted by a long-standing PHer and used by many old-school PHers, are grown to enormous proportions.

Here's such an image. It is the correct size in this post, but in my next post I will quote it.

[Clockwork Cupcake]

Clockwork Cupcake said:

Here's such an image. It is the correct size in this post, but in my next post I will quote it.

As you can see, the [img] or [pic] tag has been changed to [thumb] and is now huge.

[Jack Mansfield]

Thanks for letting us know! I'll ask dev team about it.

[Clockwork Cupcake]

This is still outstanding, and it is literally a one line fix, by putting an "if thumbnail is smaller than the original" conditional around the bit of code that replaces the image.

It's embarrassing. This is the lowest-hanging of low hanging fruit.

Are you fixing ANY bugs?

[Ben Lowden]

Thank you for the nudge on this, I can't see that a ticket has been raised with our tech team so I'll do this now and see if it's an easy fix for us to tackle soon.

[Clockwork Cupcake]

Ben Lowden said:

Thank you for the nudge on this, I can't see that a ticket has been raised with our tech team so I'll do this now and see if it's an easy fix for us to tackle soon.

[Ben Lowden]

This has now been fixed. Only caveat is that this will work moving forwards on new posts, but existing posts will not change.

[Clockwork Cupcake]

Ben Lowden said:

This has now been fixed. Only caveat is that this will work moving forwards on new posts, but existing posts will not change.

Thanks Ben

I'm guessing (inferring) from this that a new image asset is created at the time, rather than the thumbnail being generated on the fly. Which makes sense.

[Clockwork Cupcake]

Let's test it....

Clockwork Cupcake said:

Here's such an image. It is the correct size in this post, but in my next post I will quote it.

edit: Yay! A fix!

[Ben Lowden]