XS max would be better - OLED screen for a start and obviously a year newer. unless you prefer the form factor of your current phone and like fingerprint opening which the XS max doesn't have
I have an X and the screen is miles brighter than even the 11. Camera on the XS will be lightyears better than the 8 plus especially video and night photos.
I have an XS Max, Wifey has an 8 Plus. The general difference is considerable, despite them running the same OS. The XS Max screen in particular is much crisper
Facial recognition is great - only realised how great since I’ve been wearing a mask....