quoting gone awry since the new format

[Hackney]

Since the update I've noticed posts using quotes are often not quoting correctly.
For example, I just posted in the dashcam thread, quoting two previous posts

https://www.pistonheads.com/gassing/topic.asp?h=0&...

I'm not editing the quotes in any way, just adding my text at the end, but my post and one of the quotes are getting merged. It's happened several times - leading to an accusation that I don't know how to quote in one thread - but the post is fine as shown by the preview, posted below with "quote" removed the text so you just see the text

[XXXXX=acer12][XXXXX=imdeman87]Bicycle versus truck. Driver failed to stop - https://www.youtube.com/watch?v=XfGlrRS5hoU[/XXXXX...
[/XXXXX]

what's the deal with the cyclist rolling around like a football player? Idiot, it was inevitable he would become a cropper with his aggressive cycling. Knows it too well as he had disabled comments

[/XXXXX]

I'm not an expert but maybe its something to do with BEING HIT BY A fkING LORRY!

[B'stard Child]

Looks fine to me

[TooMany2cvs]

Hackney said:

Since the update I've noticed posts using quotes are often not quoting correctly.
For example, I just posted in the dashcam thread, quoting two previous posts

https://www.pistonheads.com/gassing/topic.asp?h=0&...

I'm not editing the quotes in any way, just adding my text at the end, but my post and one of the quotes are getting merged. It's happened several times - leading to an accusation that I don't know how to quote in one thread - but the post is fine as shown by the preview, posted below with "quote" removed the text so you just see the text

[XXXXX=acer12][XXXXX=imdeman87]Bicycle versus truck. Driver failed to stop - https://www.youtube.com/watch?v=XfGlrRS5hoU[/XXXXX...
[/XXXXX]

what's the deal with the cyclist rolling around like a football player? Idiot, it was inevitable he would become a cropper with his aggressive cycling. Knows it too well as he had disabled comments

[/XXXXX]

I'm not an expert but maybe its something to do with BEING HIT BY A fkING LORRY!

You can't quote. You've got two open quotes, and three closes. One at the end of the YT url, one immediately following it, then one at the very end.

Strip one of the first pair out, and it works. You've even got three [/XXXX] in your post here.

acer12 said:

imdeman87 said:

Bicycle versus truck. Driver failed to stop - https://www.youtube.com/watch?v=XfGlrRS5hoU

what's the deal with the cyclist rolling around like a football player? Idiot, it was inevitable he would become a cropper with his aggressive cycling. Knows it too well as he had disabled comments

See?

[ClockworkCupcake]

Additionally, there is an issue with nested quoting when the quotes contain your own posts. Whilst other peoples' posts are bubbled quoted, your own posts are not.

Confirmed on Firefox 52.0.2 and Chrome 57.0.2987.133, both under Windows 7 64-bit.
URL: https://www.pistonheads.com/gassing/topic.asp?h=0&...
Screen resolution: 1200x1600 portrait side screen, maximised.

Screenshot is Firefox.



A possible explanation is provided by user 768, so suggests that it's the code that highlights your own posts that is at fault. This is done client-side in Javascript and has not been updated to use the new quoting style (which I incidentally hate, but it should at least be consistent).

768 said:

FWIW highlightquotes() in mainshared.js is where the logic is that explictly changes the quote style for your own quotes.

if (tquser[1] == username) {
  ...
  quotes[i].nextSibling.nextSibling.className = "quoteHighlight";
  ...

ETA: If anyone does edit that area of the code there's a console.log() call that wants removing.

Edited by ClockworkCupcake on Wednesday 12th April 13:21

[Hackney]

B'stard Child said:

Looks fine to me

That's not fine. Acer12's post is not distinguishable from mine, the only text that's mine in that image is the line beginning, "I'm not an expert but...."

[Hackney]

TooMany2cvs said:

See?

My point is, I didn't make any changes to the quotes (other than substituting names for XXXXX.
I simply clicked on "quote all" then typed my text after the last

[Hackney]

ClockworkCupcake said:

Thanks, the first line of your post would seem to be the issue I'm having.
Interestingly if I just hit "quote" on your post I get the beginning and end quote code, but nothing is actually quoted. See above.

[TooMany2cvs]

Hackney said:

TooMany2cvs said:

See?

My point is, I didn't make any changes to the quotes (other than substituting names for XXXXX.
I simply clicked on "quote all" then typed my text after the last (/quote)

Looking back on it, I think the problem's in the post you quoted.

[ClockworkCupcake]

Hackney said:

Thanks, the first line of your post would seem to be the issue I'm having.
Interestingly if I just hit "quote" on your post I get the beginning and end quote code, but nothing is actually quoted. See above.

That's because Quote (rather than Quote All) quotes the text written by the user after the last quote and I didn't write anything below my quote of 768's post.

[B'stard Child]

Hackney said:

B'stard Child said:

Looks fine to me

That's not fine. Acer12's post is not distinguishable from mine, the only text that's mine in that image is the line beginning, "I'm not an expert but...."

Ahhh got ya!!!!